• Earthwormjim91@lemmy.world
    link
    fedilink
    arrow-up
    2
    ·
    2 hours ago

    Code should ideally be going through tests before prod anyway. There should be no code changed from successful test to prod. Proofreading shouldn’t matter at that point. Just scheduling the actual deploy.

    • BassTurd@lemmy.world
      link
      fedilink
      arrow-up
      1
      ·
      2 hours ago

      I mostly mean proof what I’ve written prior to having someone else test. I often will comment out lines when trying different things so I just make sure I clean up what I’ve done. We have a few human checks as well as some automated checks between each stage of deployment for each environment.

      • Earthwormjim91@lemmy.world
        link
        fedilink
        arrow-up
        1
        ·
        1 hour ago

        Yeah that’s what the MRs are supposed to be for. To catch those and proofread.

        There shouldn’t be any changes at all from the last test to going to production though. Even cleaning up comments.

        • BassTurd@lemmy.world
          link
          fedilink
          arrow-up
          1
          ·
          1 hour ago

          Correct. I’m just saying that I proof read my work, that I deploy things, and that I don’t proof read my texts.

          • Earthwormjim91@lemmy.world
            link
            fedilink
            arrow-up
            1
            ·
            1 hour ago

            No I got that. I’m saying that by the time the prod deploy comes around, there’s no proofreading left to do anyway.

            Not proofreading texts should have zero bearing on being able to write and deploy software because it should be proofread several times before the actual prod deployment. Hell it very likely isn’t even the same person doing the deployment that wrote the code.