Most of the places I’ve worked I’d have been told to get rid of the cursing before checking something in. But, my own personal codebase has tons of this sort of thing.
But, aside from the cursing, these actually look like excellent comments. Comments should warn you when the code isn’t what you might expect. These are excellent from that point of view. If this is what a random sampling of the comments in the codebase looks like, it is probably a very well commented codebase.
The fart sniffers are there to prevent your pull request from being accepted because they have nothing better to do. They exist because they are promoted so your manager, that contributes nothing, can point to them as a “team player”.
I swear to God. Corporate code would literally work better if we auto accepted every pull request and just had a single meeting each month to decide if we should revert back to last month and try again or accept our current state as “better”.
Fuck waterfall, Fuck agile. Just go with the “was it worth it?” monthly review method.
Did we create more problems than we solved? Like, I feel like the Windows search function wouldn’t have passed this review and we wouldn’t get 0 results for the “uninstall” search string and start suggesting Bing results if this minimal method of rational discussion existed at a higher level.
Most of the places I’ve worked I’d have been told to get rid of the cursing before checking something in. But, my own personal codebase has tons of this sort of thing.
But, aside from the cursing, these actually look like excellent comments. Comments should warn you when the code isn’t what you might expect. These are excellent from that point of view. If this is what a random sampling of the comments in the codebase looks like, it is probably a very well commented codebase.
Why are the fart sniffers reading the code? Or does the mere thought of a naughty no-no word give them the bad tingles?
The fart sniffers are there to prevent your pull request from being accepted because they have nothing better to do. They exist because they are promoted so your manager, that contributes nothing, can point to them as a “team player”.
I swear to God. Corporate code would literally work better if we auto accepted every pull request and just had a single meeting each month to decide if we should revert back to last month and try again or accept our current state as “better”.
Fuck waterfall, Fuck agile. Just go with the “was it worth it?” monthly review method.
Did we create more problems than we solved? Like, I feel like the Windows search function wouldn’t have passed this review and we wouldn’t get 0 results for the “uninstall” search string and start suggesting Bing results if this minimal method of rational discussion existed at a higher level.