Sorry I didn’t articulate myself well here at all.
What I meant was, I’ve heard this particular contributor’s history is slim to none, and suddenly he shows up and PR’s this age form into the kernel.
That’s what’s weird.
You’re exactly right, most of us probably haven’t looked at kernel PRs. Such a major component in such a major project isn’t really a “My first contribution” territory, right?
So it should raise some eyebrows when this guy just pops up and PRs it and it gets merged so quick.
I’m not the most brilliant at this stuff so I’m happily open to being educated here if I’m way off, though.
Yeah I see your point. I feel like it’s entirely reasonable, though. Like those who went to the PR, they saw something in the news and decided to do something about it with their abilities, throwing aside whether that’s good for a moment. I certainly would not call the optional JSON schema for user records a critical component especially as no existing fields were modified, just new ones.
(And FWIW it’s systemd, very different from the kenrel, though I do feel like you know what you meant to talk about. systemd’s code quality is relatively notorious anyways.)
I’m fairly sure this is the first systemd pull request that many here have viewed. I wouldn’t say we’re coming out of nowhere.
Sorry I didn’t articulate myself well here at all.
What I meant was, I’ve heard this particular contributor’s history is slim to none, and suddenly he shows up and PR’s this age form into the kernel.
That’s what’s weird.
You’re exactly right, most of us probably haven’t looked at kernel PRs. Such a major component in such a major project isn’t really a “My first contribution” territory, right?
So it should raise some eyebrows when this guy just pops up and PRs it and it gets merged so quick.
I’m not the most brilliant at this stuff so I’m happily open to being educated here if I’m way off, though.
Yeah I see your point. I feel like it’s entirely reasonable, though. Like those who went to the PR, they saw something in the news and decided to do something about it with their abilities, throwing aside whether that’s good for a moment. I certainly would not call the optional JSON schema for user records a critical component especially as no existing fields were modified, just new ones.
(And FWIW it’s systemd, very different from the kenrel, though I do feel like you know what you meant to talk about. systemd’s code quality is relatively notorious anyways.)