• freamon@lemmy.world
    link
    fedilink
    arrow-up
    16
    ·
    edit-2
    3 hours ago

    The code that OP has linked to is part of a convenience function for admins to add content to their new instances. It can query individual remote instances (e.g. lemmy.world), or it can query lemmyverse.net, and fetch communities that look to be popular and active.

    It’s completely unrelated to routine federation, and doesn’t prevent anyone subscribing to communities that may have those words in their names.

    The admin function could potentially be used to fetch hundreds of communities. It runs as a background process, so you don’t know what they were until after they’d been followed. The “bad words” list acts as a safeguard against bringing in things you might not want or expect. One reason is that you may want to curate the first impression you give new visitors, as there as some that will be put off by the “fuck this” and “shitpost that” reddit-isms. Another is that you don’t typically want communities that are disproportionately popular than others (e.g. if you bring in the default 25 communities, and one of is 196, then it completely dominate your front page).

    If there’s a particular community that you are interested in (e.g. because you moderate it), using this function isn’t an efficient way to add it. In addition to the “bad words” filters, it will also exclude communities that are NSFW, or below thresholds for popularity and activity. Rather than fetching a bunch of communities at the same time, and hoping that the one you want is included, it’s better to just add it manually (via a ! link or by using the “Add remote community” link) in much the same way as you would on any other platform.

    • OpenStars@piefed.social
      link
      fedilink
      English
      arrow-up
      2
      ·
      19 minutes ago

      It’s completely unrelated to routine federation, and doesn’t prevent anyone subscribing to communities that may have those words in their names.

      99% of commentors here seem to have precluded this as even being remotely a possibility. Sadly, much of what happened on Reddit seems to have followed us here. I suppose it’s just basic human nature.

    • Hazzard@lemmy.zip
      link
      fedilink
      arrow-up
      2
      ·
      41 minutes ago

      Yeah… I’m unsure how they thought this was a platform-wide ban when it includes terms like “meme” and “greentext”. I don’t even need to look at any more than this one line of code to intuit this does something more specific than OP thought.

  • Stefan_S_from_H@piefed.zip
    link
    fedilink
    English
    arrow-up
    6
    ·
    4 hours ago

    So many people are criticizing the code quality. This means the project will gain so many new contributors in 2026!!

    And the community-based Fediverse will see so many new forks and reimplementations!

    • nublug@piefed.blahaj.zone
      link
      fedilink
      English
      arrow-up
      9
      ·
      edit-2
      5 hours ago

      this is also a capability in a nextcloud app so an admin can more easily replicate a users bug report and see for themselves what’s going wrong. that said i struggle to see how you could implement that in such a way as to avoid abuse, but isn’t that true of any admin powers? this isn’t encrypted cloud storage, it’s a public forum. i’d imagine the process is at the very least heavily logged so other admins and maybe even federates to other instance admins or even mods too so impersonation actions are clearly visible as such. but i don’t know enough about code to read thru and see if it does in either app.

  • OpenStars@piefed.social
    link
    fedilink
    English
    arrow-up
    34
    ·
    edit-2
    11 hours ago

    If you dont like it, fork it. Stop bothering us about it

    -devs of PieFed

    Oh wait no, that’s the devs of Lemmy when asked the same request. (edit: ‘asking’ to ‘asked’)

    Hopefully Rimu will be more accommodating when you ask him? (codeberg issue creation prefered)

    It might be time to move this away from a hard-coded list now, if the expectations that someone installing an instance is going to read through the code is lower now than previously.

    • Mr. Satan@lemmy.zip
      link
      fedilink
      arrow-up
      8
      ·
      4 hours ago

      What a shit show of a discussion on that issue… Not only is hard coding bad design in general[1], but doing so for constantly evolving and highly context dependent word list is even worse. Reading the discussion I see their decision as extremely short sighted and arrogant if not just stupid.



      1. Having hard coded configurations has it’s uses, but it’s a strong red flag that might complicate maintenance down the road, and should be used with caution. ↩︎

      • OpenStars@piefed.social
        link
        fedilink
        English
        arrow-up
        1
        ·
        28 minutes ago

        Yes, likely very bad design on their part (if it is hard-coded not once but 3 times and if all 3 of those represent the same use cases), though until a few months ago not many PieFed instances existed except to test the evolving codebase, so this is all VERY new.

        See also this discussion of so many frustrating and LONG-STANDING bugs in Lemmy that the instance admins of slrpnk.net will switch to PieFed that (reportedly) is less buggy overall.

        All of the Threadiverse software is still new-ish and under active development - PieFed more than most, and what blows me away is how it is doing so even without a NLNet grant, just entirely freely developed by real people making actual contributions in return for basically nothing at all. Somehow this software being developed in a Western nation is out socialism-ing the literal communists, who btw also make it impossible to donate directly to the development of code without also supporting the heavily politicized lemmy.ml instance (which people have noticed a LOT of time is spent on moderating… time that could have been spent on code development, e.g. in fixing those long-standing bugs?).

        TLDR: the entire Threadiverse is new, and PieFed has “potential”. At least as much if not significantly more so than Lemmy. It will be good to see both of them improved in the future.

  • degenerate_neutron_matter@fedia.io
    link
    fedilink
    arrow-up
    200
    ·
    16 hours ago

    List of blocked words in community names:

    shit
    piss
    fuck
    cunt
    cocksucker
    motherfucker
    tits
    memes
    piracy
    196
    greentext
    usauthoritarianism
    enoughmuskspam
    political_weirdos
    4chan
    

    Seems like one of the PieFed devs has some opinions about the kind of content they dislike, and are unilaterally forcing that on every PieFed instance. I can somewhat understand filtering out curse words, but specific communities should not blocked by default, and definitely not hidden in a hardcoded list in the source code.

    • 0_o7@lemmy.dbzer0.com
      link
      fedilink
      English
      arrow-up
      3
      ·
      2 hours ago

      usauthoritarianism

      People were rallying on piefed on resentment from tankie Lemmy devs. But this explains where the piefed devs bias is.

      Seems like the intentions are to limit the reach of content critical of a certain country. Hmm…

    • Vespair@lemmy.zip
      link
      fedilink
      English
      arrow-up
      41
      ·
      10 hours ago

      I’m not okay with them filtering profanity, who the fuck are they to define what is or is not acceptable?

    • plyth@feddit.org
      link
      fedilink
      English
      arrow-up
      4
      ·
      7 hours ago

      kind of content they dislike

      Or they like it and e.g. want just one strong 196 community.

    • Jerkface (any/all)@lemmy.ca
      link
      fedilink
      English
      arrow-up
      54
      ·
      13 hours ago

      This isn’t the first time I’ve encountered an extremely pointed line of code in piefed meant to fuck over one person specifically. It’s very concerning now that it’s a pattern.

    • JackbyDev@programming.dev
      link
      fedilink
      English
      arrow-up
      4
      ·
      8 hours ago

      Isn’t there a Java based Lemmy compatible thing too? I forgot what it was called but I think there is one.

    • Zoot@reddthat.com
      link
      fedilink
      arrow-up
      121
      ·
      16 hours ago

      Damn this should honestly be spread and talked about more. I don’t think many people know this is a thing?

      • 4am@lemmy.zip
        link
        fedilink
        arrow-up
        125
        ·
        14 hours ago

        Considering PieFed users won’t shut the fuck up about how much better and less politically opinionated it is, yeah we should probably shout this from the rooftops.

        Reminds me of Brave browser users a bit

        • Eugene V. Debs' Ghost@lemmy.dbzer0.com
          link
          fedilink
          English
          arrow-up
          10
          ·
          edit-2
          37 minutes ago

          “Ours is not biased and less opinionated, because it agrees with my bias and opinions.”

          This is every single Lemmy v PieFed argument. No matter what platform you host or use, its just this on the grand scale of things.

        • pivot_root@lemmy.world
          link
          fedilink
          arrow-up
          18
          ·
          edit-2
          12 hours ago

          One of PyFed’s selling points was that it was easier to work with than Lemmy. It’s going to be amusing when that takes a 180 turn and people start complaining.

          Python is great for prototyping and iterating on small projects or as glue for modules written in C and C++. What it isn’t great at is linearly scaling on a single node. When the day that throwing more powerful hardware at the problem stops being an option, Kubernetes is going to walk through that door and fuck any semblance of simplicity up.

          • mushroomman_toad@lemmy.dbzer0.com
            link
            fedilink
            arrow-up
            5
            ·
            8 hours ago

            I think Lemmy has some in-memory data structures that limit the backend to a single node, too. Also postgres is great, but Lemmy really fucked up their database performance somehow.

            But yeah large python codebases turn into spaghetti really quickly.

      • qaz@lemmy.worldOP
        link
        fedilink
        English
        arrow-up
        3
        ·
        3 hours ago

        I think a regex to filter out common slurs isn’t really the same

        The regex:

        (fag(g|got|tard)?\b|cock\s?sucker(s|ing)?|ni((g{2,}|q)+|[gq]{2,})[e3r]+(s|z)?|mudslime?s?|kikes?|\bspi(c|k)s?\b|\bchinks?|gooks?|bitch(es|ing|y)?|whor(es?|ing)|\btr(a|@)nn?(y|ies?)|\b(b|re|r)tard(ed)?s?)
        

        Link to code

      • leMe@lemmy.dbzer0.com
        link
        fedilink
        arrow-up
        3
        ·
        6 hours ago

        thanks for pointing to that issue. i dont know how piefed devs reacted to this. so i will give them the benefit of the doubt: it could very well be a quick and dirty solution, never meant to last long.

        as the lemmy devs showed, it does not have to be like this at all. but i haven’t seen that much oppinionsted and defensive actions from the piefed devs.

    • 🇰 🌀 🇱 🇦 🇳 🇦 🇰 🇮 @pawb.social
      link
      fedilink
      English
      arrow-up
      57
      ·
      edit-2
      15 hours ago

      They also put “memes” and “enoughmuskspam.”

      The latter I guess could be used to stop Musk spam (since the community is literally nothing but Elon Musk news) but not allowing the word “memes” in a community name?

      Utterly stupid.

      But they do appear to be fans of Carlin based on the first 7 banned words.

      There’s no racial slurs in there either. I might have assumed this was merely an example an operator is meant to edit themselves, but these are some weird ass choices for even that.

    • FiniteBanjo@feddit.online
      link
      fedilink
      English
      arrow-up
      13
      ·
      14 hours ago

      So if I started a piefed instance and wanted to host a 196 community I’d have to edit the list, but would every single other instance also have to or no?

      • OpenStars@piefed.social
        link
        fedilink
        English
        arrow-up
        1
        ·
        2 minutes ago

        Or you could pull it in manually. It’s just that the automated startup would not do it for you, for communities with these keywords. Nothing prevents anyone from pulling in the communities manually though.

      • mic_check_one_two@lemmy.dbzer0.com
        link
        fedilink
        English
        arrow-up
        18
        ·
        13 hours ago

        Yes, every other instance would also refuse to federate unless they also changed their code. Because the blocklist is baked right into the code, so anyone just pulling and running it as-is will fail to federate.

        • FiniteBanjo@feddit.online
          link
          fedilink
          English
          arrow-up
          7
          ·
          edit-2
          10 hours ago

          It’s odd that communities with those names load if they’re hosted on Lemmy, tho. Or maybe I’ve just only been on Piefed Instances that undid the list.

    • DreamButt@lemmy.world
      link
      fedilink
      English
      arrow-up
      6
      ·
      15 hours ago

      They’re pretty explicit about what they don’t like when you sign up. That’s why I joined it

      • degenerate_neutron_matter@fedia.io
        link
        fedilink
        arrow-up
        50
        ·
        14 hours ago

        Each instance should be free to set their own rules. Individual instances blocking those communities is fine, but the PieFed devs hardcoding a blocklist that applies to all instances (especially one as opinionated and arbitrary as this) is absolutely not.

        • OpenStars@piefed.social
          link
          fedilink
          English
          arrow-up
          3
          ·
          11 hours ago

          Each instance should be free to set their own rules.

          They… are though? Maybe I am dumb, but I do not understand why each instance setting its own rules would apply to all other instances? Say if you made your own instance, you would set your own rules, but the other instances are free to set theirs as well? Like if you want to allow communities such as “4chan”, then go ahead, but if others want to block that, then why shouldn’t they be allowed to?

          Definitely agree that this issue should be made much more transparent and easier to change, like not hard-coding it.

          • degenerate_neutron_matter@fedia.io
            link
            fedilink
            arrow-up
            24
            ·
            10 hours ago

            This filter is not part of any specific instance, it’s hardcoded into PieFed’s code. That means it applies to every PieFed instance unless the instance admin explicitly patches the code to remove it.

  • NotSteve_@piefed.ca
    link
    fedilink
    English
    arrow-up
    55
    ·
    edit-2
    16 hours ago

    What, why 196? Actually why any of these? I get 4chan and greentext sort of(?) but even ignoring the terrible programming practices here, this is really stupid.

    Edit: actually almost makes me regret switching to Piefed

      • qaz@lemmy.worldOP
        link
        fedilink
        English
        arrow-up
        4
        ·
        edit-2
        35 minutes ago

        It has been removed from 2/3 places in the codebase. I’m guessing they missed the other list so I’ve opened an issue and PR on Codeberg.

      • NotSteve_@piefed.ca
        link
        fedilink
        English
        arrow-up
        30
        ·
        14 hours ago

        Ah, that’s good to hear. I’m still sketched out by the hardcoded blacklist of terms though. I’m very much a person against the sort of free speech that hinders other’s freedom to live without discrimination but the filter still seems so arbitrary and entirely the response to the dev’s own vandettas and that just gives me bad vibes.

        On top of that, hardcoding English language terms to block is bad programming on a number of levels. Why isn’t it a configurable list? The hardcoded values don’t contain any other language variants so you can still have those communities if you speak something other than English (or just add an extra couple characters or anything really)

        • OpenStars@piefed.social
          link
          fedilink
          English
          arrow-up
          1
          ·
          6 minutes ago

          Just to be absolutely clear, there is foundationally no expectation whatsoever that either PieFed or Lemmy are trying to make a “free speech” platform. Truth Social and 4chan seem to already have that covered…

          Rather, the owner of the instance (aka the one who pays for the machine and in all likelihood has to register it with their irl credentials within its country of residence, for legality purposes e.g. CSAM) gets to decide all of the rules that govern it.

          If someone wants to use the Threadiverse to e.g. spread CSAM, they are welcome to make a fork but that’s not what either PieFed or Lemmy (or Mbin, Mastodon, nodeBB, etc.) are about.

          Anyone is free to say whatever they want, but none of this software is not bound to have to offer a platform to send those thoughts out to everyone, particularly those who do not want it.

    • FiniteBanjo@feddit.online
      link
      fedilink
      English
      arrow-up
      5
      ·
      edit-2
      10 hours ago

      Maybe they’ve had a bad experience with the 196 moderators, as many have. I hope that’s all it is.

      • Holytimes@sh.itjust.works
        link
        fedilink
        arrow-up
        15
        ·
        9 hours ago

        The mods are awful. But basically all mods are awful. You have to have brain damage to want to be a moderator of an online community.

        So it is a bit of a catch 22

    • vga@sopuli.xyz
      link
      fedilink
      arrow-up
      2
      ·
      edit-2
      9 hours ago

      Insane toxic trolls are insane toxic trolls regardless of how virtuous you might think their “cause” is.

  • ben@lemmy.zip
    link
    fedilink
    English
    arrow-up
    55
    ·
    17 hours ago

    Jesus that’s a lot of spaghetti code, and why are they hardcoding a bunch of terms? Is this just for a public facing site, or does every deployed instance effectively filter these out?

    • qaz@lemmy.worldOP
      link
      fedilink
      English
      arrow-up
      72
      ·
      edit-2
      5 hours ago

      It’s hardcoded in the PieFed source code, so every instance does this by default unless you patch it like I did.

      The combined swearwords + excluded communities list seems to appear at least 3 times in the codebase (not referenced, copied verbatim).

      Let’s just say that it wouldn’t pass my code review if I saw this at work

      EDIT: It has been removed from 2/3 places in the codebase.

    • BruisedMoose@piefed.social
      link
      fedilink
      English
      arrow-up
      12
      ·
      17 hours ago

      Yeah. The list should be in the site config. Go ahead and include those as defaults to block, but allow sites to override that.

      OP, are you saying that the federation is blocked on the OUTGOING side? Because then that just seems bass ackwards.

      • qaz@lemmy.worldOP
        link
        fedilink
        English
        arrow-up
        7
        ·
        16 hours ago

        No, it’s incoming. When you first set up an instance you have to kickstart the federation process by adding communities to federate. The linked code excludes those specified communities from that. Once federated, they won’t be blocked AFAIK.

  • Endymion_Mallorn@kbin.melroy.org
    link
    fedilink
    arrow-up
    23
    ·
    16 hours ago

    Well, like the Lemmy devs, I guess the PieFed devs have decided to plant a flag instead of making a neutral platform for federated communication.